Technology
2 min read
If I had to pick the single highest-leverage activity for a small engineering team, I would not pick architecture, hiring, or even product. I would pick code review. Done right, every pull request is a tiny seminar where the team writes its handbook in real time. Done wrong, it becomes the place where seniors flex and juniors disengage.
What a good review feels like to receive
- You finish reading the comments and you understand why something is being asked, not just what.
- The reviewer praised one thing — even small — that you did well.
- The next change you write is better, not because you were scolded but because you saw a pattern you can apply.
What a bad review feels like
- "Nit:" sprinkled on twenty things, never on one important one.
- Comments that are demands without reasoning ("change this to X").
- A long delay, then a thread that took longer to resolve than the code took to write.
Rules I follow as a reviewer
- Two reads. First read for "do I understand the change?" Second read for "would I have built it differently?"
- Praise something specific. If nothing earns praise, you're either too senior to be reviewing this or too junior to recognize the work.
- Ask, don't dictate. "Could we extract this into a function?" not "extract this into a function."
- Distinguish blocking from non-blocking. Mark "nit", "consider", or "must" so the author knows which battles to fight.
- Reply quickly to replies. Threads die if the reviewer disappears for two days.
Rules I follow as an author
- Small PRs. If the diff is over 400 lines, you're asking for a worse review.
- Tell the story. The PR description is a contract: what, why, how to verify.
- Pre-review yourself. Read your own diff before clicking "request review".
- Defend, don't dig in. When you're wrong, accept it and move on. Reviews are not court.
Reviews are slow, repetitive, undramatic, and they compound — which is exactly why they matter.
Tagged with:
Login to comment
To post a comment, you must be logged in. Please login. Login
Comments (6)
By Ali Omoum
Dec 27, 2025What are your thoughts on AI-generated content and SEO?
By Ali Omoum
Dec 27, 2025Can you share more about keyword placement in headings?
By Ali Omoum
Dec 27, 2025Is there a recommended length for blog content to rank well in 2025?
By Ali Omoum
Dec 27, 2025Thanks for the insight! I was wondering the same.
By Ali Omoum
Dec 27, 2025Can you do a follow-up post on Google Search Console setup?
By Ali Omoum
Dec 27, 2025Thanks for the insight! I was wondering the same.